[Webkit-unassigned] [Bug 21724] Correct Build Regressions (Win32-Cairo)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21724





------- Comment #4 from bfulgham at gmail.com  2008-10-18 17:27 PDT -------
[11:01am] bfulgham_: dhyatt:  Could you please take a look at
https://bugs.webkit.org/attachment.cgi?id=24478, specifically the two small
modifications to WebCore/platform/win/ScrollbarThemeWin.cpp and
WebKit/win/WebView.cpp?
[11:01am] bfulgham_: dhyatt:  They are needed to address some build problems
under Win/Cairo; I *think* they are safe (and correct) for the Apple Windows
build, but wanted a second opinion.
[11:03am] dhyatt: bfulgham_: i don't get the change to webview.cpp
[11:29am] bfulgham_: dhyatt:  WebView.cpp is needed because the
setShouldPaintNativeControls is #if/def'd in WebCore\page\Settings.h
conditionally on SAFARI_THEME.  This just makes WebView match Settings.h;
perhaps it should not be conditional in Settings.h?
[11:29am] dhyatt: oh ok
[11:29am] dhyatt: sounds ok


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.