[Webkit-unassigned] [Bug 21724] Correct Build Regressions (Win32-Cairo)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21724





------- Comment #3 from bfulgham at gmail.com  2008-10-18 11:00 PDT -------
(In reply to comment #2)
> (From update of attachment 24478 [edit])
> I'm concerned that the project file changes will break the cf build as you
> replace cf paths with the curl paths instead.  You may want to talk to sfalken
> about those as he has a much greater understanding of vcproj-fu than i do.

I am pretty sure these changes are safe.  Visual Studio stores these include
paths on a per-configuration basis.  So my modifications for "Debug_Cairo" and
"Release_Cairo" should not harm the "Debug" and "Release" targets.  The Cairo
variants already have some differences from the 'main' Windows build.

> I'd also like you to discuss the changes to
> WebCore/platform/win/ScrollbarThemeWin.cpp and WebKit/win/WebView.cpp with
> dhyatt as i suspect they will break the "standard" windows build

Sounds good.  I'll see if I can catch sfalken or dhyatt next time they are on
line.

Thanks for looking it over! 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.