[Webkit-unassigned] [Bug 21541] New: Move RegisterFile growth check to callee and JIT "correct number of arguments" case of op_call

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21541

           Summary: Move RegisterFile growth check to callee and JIT
                    "correct number of arguments" case of op_call
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cwzwarich at uwaterloo.ca
                CC: barraclough at apple.com
OtherBugsDependingO 20812
             nThis:


We currently do the RegisterFile growth check in the caller, when it should
really be in the callee, except in the case where there are too few arguments
and you need to fill the unpassed ones with jsUndefined().

If we do this, then we can conceivably inline the "correct number of arguments"
case of op_call in the generated machine code. The only thing preventing this
is the check for the existence of the CodeBlock on the JSFunction, but this
could possibly be done in assembly with a jump to a slow case.

I have a patch to only move the check to the callee that is a wash on V8's
benchmark suite and a slight speedup on SunSpider, but I might be able to speed
it up a bit more. I will post it.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.