[Webkit-unassigned] [Bug 21365] WebKit supports <font descent= but should support <font-face descent=!

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21365





------- Comment #9 from mitz at webkit.org  2008-10-04 10:45 PDT -------
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (From update of attachment 24087 [edit] [edit] [edit])
> > > Is it still correct to return early if m_fontElement is NULL?
> > > 
> > 
> > I don't know what the effect would be of moving the check below this logic.  I
> > chose to leave it above so as not to change behavior.  I'm not sure how you'd
> > ever get a SVGFontFaceElement to be asked for its ascent/descent w/o having a
> > wrapping <font> element, but I don't know the SVG font code very well.
> > 
> 
> I'd rather leave the !NULL check at the top of each of these functions so that
> it's the same as all the rest.  Right now if the SVGFontFaceElement has not
> SVGFontElement associated with it, then all calls return 0.0f
> 

This seems wrong and means that the descent attribute will have no effect on
out-of-document SVG fonts. It's not like "all the rest". See unitsPerEm() and
xHeight().


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.