[Webkit-unassigned] [Bug 21365] WebKit supports <font descent= but should support <font-face descent=!

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21365





------- Comment #10 from eric at webkit.org  2008-10-05 00:58 PDT -------
(In reply to comment #8)
> (From update of attachment 24087 [edit])
> Looks fine, but I would have put this and the test changes into a single patch.
> 
> +    AtomicString value = getAttribute(ascentAttr);
> 
> To avoid a little reference count churn, this really should be const
> AtomicString& value.
> 
> r=me

Oh, they'll land as a single patch.  That's just teh magic of git. :)  I broke
them out to make them easier to review.
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.