[Webkit-unassigned] [Bug 21365] WebKit supports <font descent= but should support <font-face descent=!

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21365


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24087|review?                     |review+
               Flag|                            |




------- Comment #8 from darin at apple.com  2008-10-04 08:22 PDT -------
(From update of attachment 24087)
Looks fine, but I would have put this and the test changes into a single patch.

+    AtomicString value = getAttribute(ascentAttr);

To avoid a little reference count churn, this really should be const
AtomicString& value.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.