[Webkit-unassigned] [Bug 21365] WebKit supports <font descent= but should support <font-face descent=!

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21365





------- Comment #7 from eric at webkit.org  2008-10-04 03:10 PDT -------
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 24087 [edit] [edit])
> > Is it still correct to return early if m_fontElement is NULL?
> > 
> 
> I don't know what the effect would be of moving the check below this logic.  I
> chose to leave it above so as not to change behavior.  I'm not sure how you'd
> ever get a SVGFontFaceElement to be asked for its ascent/descent w/o having a
> wrapping <font> element, but I don't know the SVG font code very well.
> 

I'd rather leave the !NULL check at the top of each of these functions so that
it's the same as all the rest.  Right now if the SVGFontFaceElement has not
SVGFontElement associated with it, then all calls return 0.0f


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.