[Webkit-unassigned] [Bug 21322] DumpRenderTree pixel test improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21322





------- Comment #7 from pol at apple.com  2008-10-03 11:54 PDT -------
(In reply to comment #6)
> It also looks like you removed the
> code path that reads pixels back from the window backing store, and instead you
> always have the view paint itself directly into your bitmap context. Does that
> not break the invalidation tests that use layoutTestController.display() (many
> of the tests in fast/repaint)?

Indeed, this created a problem in this code path: I'll revert this part of the
patch.

I guess there's nothing to change regarding the "AppleFontSmoothing" default
since rendering happens to the window backbuffer no matter what and font
smoothing will work there. The advantage is that base images don't need to be
regenerated.

However, there's still an issue with the --repaint option for the DRT tool: the
previous code path that was rendering directly to the CGContext hasn't changed.
So either 1) you have font smoothing and different hashes for PPC / X86, 2) no
font smoothing, but consistent hashes or 3) change this code path to also go
through the window backbuffer.

Is this option used? If yes, in which tests?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.