[Webkit-unassigned] [Bug 21322] DumpRenderTree pixel test improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21322





------- Comment #6 from mitz at webkit.org  2008-10-03 10:41 PDT -------
(In reply to comment #5)
> It seems simpler to generate the same pixels on PPC or X86, so that the MD5
> hashes match. That's why it now renders to RGBA8 independently of the
> endianness. A side effect of this is that because CG font smoothing is only
> supported for (kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host), you
> can't have a common pixel format and font smoothing.

I see. Still, I would remove the discussion of font smoothing from the comment
and change the font smoothing setting in
setDefaultsToConsistentValuesForTesting(). It also looks like you removed the
code path that reads pixels back from the window backing store, and instead you
always have the view paint itself directly into your bitmap context. Does that
not break the invalidation tests that use layoutTestController.display() (many
of the tests in fast/repaint)?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.