[Webkit-unassigned] [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22441





------- Comment #7 from darin at apple.com  2008-11-24 11:56 PDT -------
(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 25404 [review] [review])
> > > +typedef PassRefPtr<$parameters{'namespace'}Element> (*ConstructorFunc)(Document* doc, bool createdByParser);
> > 
> > There should not be a space between the ">" and the "(" symbols.
> 
> I am not sure about this one: we are putting a space between the type and the
> name in other typedef's like in the FrameLoader.h
> (http://trac.webkit.org/browser/trunk/WebCore/loader/FrameLoader.h#L96). So I
> would prefer being conservative and matching the existing implicit coding
> style.

Oops, my mistake. There *should* be a space here. Sorry, I was wrong.

> > Headers should not include the "config.h" header; that's to be included by cpp
> > files only.
> 
> I have to disagree here. Our coding style states that all files should include
> "config.h" first.

Yes, I see that's what the coding style document says, but it's wrong.

All implementation files should include "config.h" first; header files should
never include "config.h". If you look at the actual code checked in to the tree
see that despite what the coding style document says, there is no ".h" file
that includes "config.h" except for these 5 files that have it wrong:

    JavaScriptCore/runtime/CollectorHeapIterator.h
    JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h
    WebCore/svg/Filter.h
    WebCore/svg/FilterBuilder.h
    WebKit/wx/WebViewPrivate.h

These are all wrong and the patch should not be landed this way. We've
discussed this many times in the past. But until now I didn't realize that
<http://webkit.org/coding/coding-style.html> had this wrong.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.