[Webkit-unassigned] [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 11:44:11 PST 2008


------- Comment #6 from jchaffraix at pleyo.com  2008-11-24 11:44 PDT -------
(In reply to comment #4)
> (From update of attachment 25404 [review])
> > +typedef PassRefPtr<$parameters{'namespace'}Element> (*ConstructorFunc)(Document* doc, bool createdByParser);
> There should not be a space between the ">" and the "(" symbols.

I am not sure about this one: we are putting a space between the type and the
name in other typedef's like in the FrameLoader.h
(http://trac.webkit.org/browser/trunk/WebCore/loader/FrameLoader.h#L96). So I
would prefer being conservative and matching the existing implicit coding

> Headers should not include the "config.h" header; that's to be included by cpp
> files only.

I have to disagree here. Our coding style states that all files should include
"config.h" first.

> I don't see the change to the createElement definition.

I have removed it at the last minute as it was not really needed and forgot to
update the ChangeLog.

The other issues you mentioned will be addressed in a later version and should
have been part of my clean-up from the beginning. Thanks for pointing them out!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list