[Webkit-unassigned] [Bug 22039] Update LayoutTests/platforms/gtk/Skipped - get the LayoutTests going

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22039





------- Comment #21 from zecke at selfish.org  2008-11-23 07:56 PDT -------
(From update of attachment 25397)

> +TestNetscapePlugin_libtestnetscapeplugin_la_SOURCES = \
> +	WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/PluginObject.cpp \
> +	WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/PluginObject.h \
> +	WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestObject.cpp \
> +	WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestObject.h

^^^^^ these can be taken directly from the shared
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/ directory. There is no
reason to have a 1:1 copy

> +	WebKitTools/DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp \

okay, this is copied from the main.cpp of the above directory. The only
difference is the handle event method?

> Index: WebKitTools/Scripts/run-webkit-tests
> ===================================================================
> --- WebKitTools/Scripts/run-webkit-tests	(revision 38694)
> +++ WebKitTools/Scripts/run-webkit-tests	(working copy)
> @@ -334,6 +334,21 @@ my %testType = ();
>  
>  system "ln", "-s", $testDirectory, "/tmp/LayoutTests" unless -x "/tmp/LayoutTests";
>  
> +# On GTK port, copy libtestnetscapeplugin.so into temporary directory
> +# FIXME: Make this temporary directory possible to change through some argument
> +#        and set the environment variable PluginDatabase can then use.

a) you can cheat with the MOZHOME environment variable. You just need
$MOZHOME/plugins available.
b) we can add SemiPublicInterface to add a plugin path... or just add proper
API and call it
   from DumPRenderTree 


> Index: LayoutTests/platform/gtk/Skipped
> ===================================================================
> --- LayoutTests/platform/gtk/Skipped	(revision 38694)
> +++ LayoutTests/platform/gtk/Skipped	(working copy)

cool


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.