[Webkit-unassigned] [Bug 22039] Update LayoutTests/platforms/gtk/Skipped - get the LayoutTests going
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 23 07:38:43 PST 2008
https://bugs.webkit.org/show_bug.cgi?id=22039
zecke at selfish.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25397|review? |review-
Flag| |
------- Comment #20 from zecke at selfish.org 2008-11-23 07:38 PDT -------
(From update of attachment 25397)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 38694)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,14 @@
> +2008-11-23 Zan Dobersek <zandobersek at gmail.com>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Add "/tmp/webkit-test-plugin" to PluginDatabase's paths on Gtk+
> + port so run-webkit-tests script has a proper place to copy test
> + plugin to.
> +
> + * plugins/PluginDatabase.cpp:
> + (WebCore::PluginDatabase::defaultPluginDirectories):
> +
> 2008-11-22 Nikolas Zimmermann <nikolas.zimmermann at torchmobile.com>
>
> Reviewed by Holger Freyther.
> Index: WebCore/plugins/PluginDatabase.cpp
> ===================================================================
> --- WebCore/plugins/PluginDatabase.cpp (revision 38694)
> +++ WebCore/plugins/PluginDatabase.cpp (working copy)
> @@ -300,6 +300,13 @@ Vector<String> PluginDatabase::defaultPl
> paths.append("/usr/lib64/netscape/plugins")
> paths.append("/usr/lib64/mozilla/plugins");
>
> +#if PLATFORM(GTK)
> + // On GTK port, test plugin gets copied into a temporary directory
> + // FIXME: Make this directory changeable through environment variable
> + // that run-webkit-tests sets
> + paths.append("/tmp/webkit-test-plugin");
> +#endif
> +
Sorry for the drastic review. But this is a security issue and I don't want
anyone to say r=+. Anyone can create /tmp/webkit-test-plugin and apps like
epiphany/midori will load random plugins....
>
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list