[Webkit-unassigned] [Bug 21991] Add Scons-based build system for Chromium's WebKit build into webkit.org

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21991





------- Comment #9 from eric at webkit.org  2008-11-04 12:33 PDT -------
(In reply to comment #8)
> +  'kjs/debugger.cpp',
> +  'kjs/DebuggerCallFrame.cpp',
> 
> This is out-of-date with TOT, these files and others have been renamed or moved
> recently.

Yup, it's hard to keep up!  I'll sync and update the patch shortly.

> Also why do we need this? I thought Chromium didn't use JavaScriptCore?

Well, so this is not the complete solution by far.  Chromium does have a build
using JavaScriptCore.  I tried to design this build file so that other
platforms/configurations could use it if they so chose, but I assume that only
Chromium will use it in the short term.

> Why does JavaScriptCore and jsc shell need to be separate? Shouldn't we just
> make both all the time? Or is that what SConstruct does? Is SConstruct the
> required name? Because as-is, it is not self-evident.

They don't need to be in separate SConscript files.  SConstruct is not the
*required* name, but it is the default "scons" will look for in the directory. 
SConscript is the conventional name for the supporting script files, however
Steven says authors have started to favor "TargetName.scons" instead of the
generic "SConscript" name.

SCons files are just python, so they can be named whatever and be located
wherever.

> Is it possible to build jsc.scons without JavaScriptCore.scons? I don't see an
> indication of dependancy. (I also don't know a bit about Scons.)

Not currently, no.  Scons files just define the dependency graph, and then the
commands like "Program()" and "SharedLibrary()" execute on those dependencies. 
I don't even know how you specify dependencies like the jsc "target" depending
on JavaScriptCore yet.

Also, note these files do not really build the chromium build yet.  They build
the "mac" build of JavaScriptCore.  I'll be fixing them up to work with the
Chromium build shortly when we bring our chromium buildbot online (hopefully
tomorrow).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.