[Webkit-unassigned] [Bug 19076] SquirrelFish: RegisterFile can be corrupted if implictly reenter global scope with no declared vars
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 15 12:46:36 PDT 2008
http://bugs.webkit.org/show_bug.cgi?id=19076
------- Comment #5 from oliver at apple.com 2008-05-15 12:46 PDT -------
(In reply to comment #4)
> (From update of attachment 21161 [edit])
> It's a little squirrely to have a variable named "m_thisRegister" that's only
> valid if we happen to be compiling program code.
>
> I'd recommend setting m_thisRegister when compiling function code and eval code
> as well. Then, "thisRegister()" can always return m_thisRegister, which makes a
> lot more sense.
>
> Eventually, we'll won't put "this" in the symbol table at all.
>
> r=me
>
I agree, but that cost of retrieving the this register for function/evalnode
codegenerator was a regression -- but that was before we rolled out the patch
o' badness
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list