[Webkit-unassigned] [Bug 19076] SquirrelFish: RegisterFile can be corrupted if implictly reenter global scope with no declared vars

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 15 09:55:12 PDT 2008


ggaren at apple.com changed:

           What    |Removed                     |Added
  Attachment #21161|review?                     |review+
               Flag|                            |

------- Comment #4 from ggaren at apple.com  2008-05-15 09:55 PDT -------
(From update of attachment 21161)
It's a little squirrely to have a variable named "m_thisRegister" that's only
valid if we happen to be compiling program code.

I'd recommend setting m_thisRegister when compiling function code and eval code
as well. Then, "thisRegister()" can always return m_thisRegister, which makes a
lot more sense.

Eventually, we'll won't put "this" in the symbol table at all.


Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list