[Webkit-unassigned] [Bug 17769] WebKit compilation fixes for HP/UX acc

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17769


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19667|review?                     |review-
               Flag|                            |




------- Comment #6 from darin at apple.com  2008-03-11 12:30 PDT -------
(From update of attachment 19667)
This is not correctly using include files. Definitions like this should not be
in Platform.h.

What *should* go in Platform.h is a definition to let us use COMPILER() to
identify the HP compiler.

The actual macro can either go in ListHashSet.h or a new header, but should not
go in Platform.h.

Have you checked to see if you can leave typename out with the other compilers?
Maybe this doesn't require a macro at all?

If it does require a macro, then I don't think WTF_TYPENAME is descriptive
enough. It makes it sound like you have to use this everywhere, when really
it's only for a few specific call sites. The name will probably need to mention
HP specifically.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.