[Webkit-unassigned] [Bug 17769] WebKit compilation fixes for HP/UX acc

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17769


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19666|review?                     |review-
               Flag|                            |




------- Comment #7 from darin at apple.com  2008-03-11 12:32 PDT -------
(From update of attachment 19666)
This workaround does not belong in Platform.h. That file only defines macros to
identify the platform, not workarounds for bugs or anything like that. It
should not be commandeered for this new purpose.

+#if (defined(_MSC_VER) && _MSC_VER-0 < 1300 && !defined(__INTEL_COMPILER)) ||
defined(__sgi) || (defined(__HP_aCC) && defined(__ia64))

This is not how we do things with the Platform.h file. You should be using the
COMPILER() macros defined in there and adding new ones as needed.

This should go in a new header file. There may be some clever way of including
it in all the projects, but adding it to Platform.h is not right.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.