[Webkit-unassigned] [Bug 19357] [GTK] Loading of resource images

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 24 08:50:49 PDT 2008


------- Comment #4 from freyther at handhelds.org  2008-06-24 08:50 PDT -------
   + I like the idea of using GtkIconTheme
   - You want to handle "missingImage", "nullPlugin", "urlIcon",
   - You certainly don't want to use missingImage for nullPlugin
   - The tricky part where I lack an answer is if we want to install the webkit
icons for the above somewhere? Should we embed them in the code? Does the fdo
icon theme spec have some icons we could reuse?

so I'm more tempted to say r=-.

style comments:
   - We tend to do early exits in error cases instead of deeply nesting the
success cases

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list