[Webkit-unassigned] [Bug 19727] Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so many times in Cairo and Qt ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19727





------- Comment #10 from jonathon.jongsma at collabora.co.uk  2008-06-23 13:29 PDT -------
(In reply to comment #9)
> (From update of attachment 21887 [edit])
> +    return color.isValid() && color.alpha() &&
> +        (blur || m_common->state.shadowSize.width() ||
> m_common->state.shadowSize.height());
> 
> Heh, I just realized that invalid colors are guaranteed to have an alpha of 0,
> so you don't need the isValid check at all.
> 
> +        (blur || m_common->state.shadowSize.width() ||
> m_common->state.shadowSize.height());
> 
> Why not use size here instead of m_common->state.shadowSize?

oops, I guess because I just re-used code from my previous hasShadow() patch
that didn't have locals.  It would be cleaner if it just used the local, I
admit.  

Would you like me to resubmit a new patch?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.