[Webkit-unassigned] [Bug 19727] Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so many times in Cairo and Qt ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19727


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21887|review?                     |review+
               Flag|                            |




------- Comment #9 from darin at apple.com  2008-06-23 13:01 PDT -------
(From update of attachment 21887)
+    return color.isValid() && color.alpha() &&
+        (blur || m_common->state.shadowSize.width() ||
m_common->state.shadowSize.height());

Heh, I just realized that invalid colors are guaranteed to have an alpha of 0,
so you don't need the isValid check at all.

+        (blur || m_common->state.shadowSize.width() ||
m_common->state.shadowSize.height());

Why not use size here instead of m_common->state.shadowSize?

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.