[Webkit-unassigned] [Bug 19415] CSSParser needs a bath

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=19415


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21558|                            |review?
               Flag|                            |




------- Comment #25 from eric at webkit.org  2008-06-07 03:07 PDT -------
Created an attachment (id=21558)
 --> (http://bugs.webkit.org/attachment.cgi?id=21558&action=view)
        Reviewed by ap.


        More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
        Remove CSSParser::current and CSSParser::currentParser and use
        the magic of YYLEX_PARAM instead.

        * css/CSSParser.cpp:
        (WebCore::enterGeneratedParser):
        (WebCore::CSSParser::parseSheet):
        (WebCore::CSSParser::parseRule):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::parseMediaQuery):
        * css/CSSParser.h:
---
 WebCore/ChangeLog         |   18 ++++++++++++++++++
 WebCore/css/CSSGrammar.y  |   14 +++++++++++---
 WebCore/css/CSSParser.cpp |   41 +++++------------------------------------
 WebCore/css/CSSParser.h   |    6 +-----
 4 files changed, 35 insertions(+), 44 deletions(-)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.