[Webkit-unassigned] [Bug 19415] CSSParser needs a bath

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 7 02:59:34 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19415


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21557|review?                     |review+
               Flag|                            |




------- Comment #24 from ap at webkit.org  2008-06-07 02:59 PDT -------
(From update of attachment 21557)
+            parsedValue = new
CSSFontFaceSrcValue(KURL(m_styleSheet->baseURL(), value).string(), false);

StyleBase::baseURL() returns KURL, you can avoid copying here (repeated several
times).

+    if (!m_styleSheet->isCSSStyleSheet())
         return 0;

This looks like it should be omitted (also, more than once).

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list