[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 21:43:16 PST 2008


------- Comment #31 from alp at atoker.com  2008-01-30 21:43 PDT -------
(In reply to comment #30)
> It's probably not worth trying to clean up this code. The print spooler has
> already been abstracted and just needs to be svn mv'd down into WebCore before
> we can kill the Win implementation completely. Fixing trivial style violations
> in existing code, especially code that's near end of life, makes the important
> parts of this patch harder to review.

Now that the coding style changes have been done, it's probably not worth
removing them. Just worth noting this for future reference.

The WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivate.h changes
look spurious in the patch. Is this just an artifact of git/svn cp? I see the
whole content of the file is added and then removed.

Patch looks good apart from these and some nit-picks (I think it's a bit too
early to split some of these files -- I have a feeling they're going to merge
back in a few commits as platform-specific code is removed.) Still, best to get
this landed now and continue to develop it in tree.

Looks fine on the GTK+ side.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list