[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 21:10:31 PST 2008


------- Comment #30 from alp at atoker.com  2008-01-30 21:10 PDT -------
(In reply to comment #24)
> (From update of attachment 18740 [edit])
> Once you're inside a CG file, there is no need to conditionalize the header
> include (see FrameCGWin.cpp).
> What's
> // FIXME: Ideally we'd have an isPluginView() here but we can't add that to the
> open source tree right now.
> ?
> We use static_cast in c++ code instead of c-style casts:
> (float)printRect.height()
> Unnecessary float-double conversion here:
> float printedPagesHeight = 0.0;
> 0.0f instead.
> Spaces after commas:
> pages.append(IntRect(0,printedPagesHeight,currPageWidth,currPageHeight));
> Again:
> IntRect ir((int)fr.x(), (int)fr.y(),(int)fr.width(),(int)fr.height());
> If I'm picking on you about existing code that's somehow showing up as + lines,
> my apologies... I should be picking on aroben or whatever Apple windows hacker
> violated their own published guidelines. :)

It's probably not worth trying to clean up this code. The print spooler has
already been abstracted and just needs to be svn mv'd down into WebCore before
we can kill the Win implementation completely. Fixing trivial style violations
in existing code, especially code that's near end of life, makes the important
parts of this patch harder to review.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list