[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 27 19:28:04 PST 2008


------- Comment #19 from darin at apple.com  2008-01-27 19:28 PDT -------
(In reply to comment #18)
> Okay guys, I've been asked to removed the 'notImplemented' calls in one review,
> and now am asked to add them back in for the current review.

I don't think I asked you to add them back. I told you to put the #if around
the entire function.

My take:

    - A build failure is OK.
    - A notImplemented() is OK.
    - A broken function that compiles but does the wrong thing at runtime is
much less OK.

If the function isn't implemented, either #if it so it's entirely omitted, or
put something there to indicate it's not implemented. The imageFromSelection
looks to me it will compile, but just do the wrong thing. It would be better to
put the #if *around* imageFromSelection rathe than compiling an empty function.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list