[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 27 16:09:14 PST 2008


------- Comment #18 from bfulgham at gmail.com  2008-01-27 16:09 PDT -------
>From comment #4 From Adam Roben 2008-01-23 08:34 PDT [reply]
> > On second thought, the "#else with a notImplemented() after the CAIRO case" may
> > be overkill. At your discretion.
> Yeah, I think a build failure is as good as or better than all those
> notImplemented()s.

(In reply to comment #17)
> The imageFromSelection function looks improperly ifdef'd here. You've put the
> entire body of the function inside and if and not provided an else case. I
> suggest putting the #if around the entire function, including the function name
> and arguments, or providing at least a call to notImplemented().

Okay guys, I've been asked to removed the 'notImplemented' calls in one review,
and now am asked to  add them back in for the current review.  Could the Apple
folks at least be consistent with how this should work?

As for the other comments, I'm revising the patch to break into multiple files
as you suggest (and as discussed in the earlier comments and IRC discussion).

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list