[Webkit-unassigned] [Bug 16779] Make the PluginStream implementation be shared across platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 8 09:27:07 PST 2008


dobey at wayofthemonkey.com changed:

           What    |Removed                     |Added
  Attachment #18323|0                           |1
        is obsolete|                            |
  Attachment #18328|                            |review?
               Flag|                            |

------- Comment #3 from dobey at wayofthemonkey.com  2008-01-08 09:27 PDT -------
Created an attachment (id=18328)
 --> (http://bugs.webkit.org/attachment.cgi?id=18328&action=view)
Updated patch to fix issues in previous review

This patch resolves the #if 0'd code issue by implementing the
PluginStreamClient class, and updating PluginViewWin to inherit from it. It
also adds a deleteFile() call for platforms other than win32, to remove the
temp file. Win32 uses ::DeleteFileA for the temp file, while deleteFile uses
::DeleteFileW, so we use an #if PLATFORM(WIN) to call ::DeleteFileA, and call
deleteFile for other platforms.

Can someone please test that this patch builds and works on Win32? It needs to
be tested there before being landed. Thanks.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list