[Webkit-unassigned] [Bug 16779] Make the PluginStream implementation be shared across platforms

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16779


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18323|review?                     |review-
               Flag|                            |




------- Comment #2 from mrowe at apple.com  2008-01-07 21:04 PDT -------
(From update of attachment 18323)
I love the direction this is heading in!  Two issues that I have noticed:  
+#if 0
+    if (!m_loadManually)
+        m_pluginView->disconnectStream(this);
+#endif

I don't think this code can be omitted.  We don't land code with #if 0's in it
either.


And:
+#if PLATFORM(WIN)
+    if (!m_path.isNull())
+        ::DeleteFileA(m_path.data());
+#endif

Looking at the code, this suggests that the file is only removed on Windows. 
The removal of the temporary file should also be abstracted into FileSystem.h
and called on all platforms.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.