[Webkit-unassigned] [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 10:55:09 PST 2008


anyang.ren at gmail.com changed:

           What    |Removed                     |Added
  Attachment #18245|review?                     |
               Flag|                            |
  Attachment #18245|0                           |1
        is obsolete|                            |
  Attachment #18315|                            |review?
               Flag|                            |

------- Comment #23 from anyang.ren at gmail.com  2008-01-07 10:55 PDT -------
Created an attachment (id=18315)
 --> (http://bugs.webkit.org/attachment.cgi?id=18315&action=view)
Proposed patch v4.1

The only difference from patch v4 is to use 0 instead of NULL for null

I think I can improve the patch more if I understand the code better. 
Specifically, I suspect that the condition
(token->attrs && currAttr < token->attrs->length()) must be true
because the guide string and the attribute array should be created
in sync in HTMLTokenizer.cpp; if the condition
(token->attrs && currAttr < token->attrs->length()) is false, I
believe it indicates a bug in HTMLTokenizer::parseTag().

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list