[Webkit-unassigned] [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 4 14:00:09 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=15960





------- Comment #22 from eric at webkit.org  2008-01-04 14:00 PDT -------
(From update of attachment 18245)
In general this fix looks fine.  The style guidelines require using 0 instead
of NULL for new C++ code.  Also, an ideal test case would say "PASS" or
"FAILURE" so as not to require user interaction.  However the change as a whole
looks fine.  I'll let someone who actually has knowledge about the viewsource
code give the final review.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list