[Webkit-unassigned] [Bug 22631] Streamline Console.cpp, abstract out the use of JSC::ExecState and JSC::ArgList by introducing ScriptCallFrame and ScriptStackTrace abstractions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 09:44:57 PST 2008


timothy at hatcher.name changed:

           What    |Removed                     |Added
  Attachment #25714|review?(ggaren at apple.com)   |review-
               Flag|                            |

------- Comment #4 from timothy at hatcher.name  2008-12-04 09:44 PDT -------
(From update of attachment 25714)
This patch looks good. Though I think the ScriptCallFrame and ScriptStackFrame
classes are not clear.

I think more needs to be moved to ScriptStackFrame (like arguments, lineNumber
and sourceURL). Then call ScriptCallFrame ScriptCallStack, and make it only
return ScriptStackFrames. That would be a better design, and give more

I like the CustomArgumentHandling changes and the Firebug compat

r- based on the ScriptCallFrame and ScriptStackFrame classes design.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list