[Webkit-unassigned] [Bug 22631] Streamline Console.cpp, abstract out the use of JSC::ExecState and JSC::ArgList by introducing ScriptCallFrame and ScriptStackTrace abstractions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22631





------- Comment #5 from dglazkov at chromium.org  2008-12-04 10:02 PDT -------
Cool! I am glad you like it. What do you think about this idea?

* Move lineNumber, functionName, sourceURL to ScriptStackFrame
* Keep argument and frame accessors on ScriptCallFrame

This way, the stack trace is cleanly represented as a collection of
ScriptCallFrames and ScriptCallFrame is essentially a way to access arguments
and/or stack trace of the current call.

I don't see why we need to move arguments to ScriptStackFrame... unless you're
thinking about eventually displaying the arguments for each frame?

As an aside note, the first frame in stack trace will have to be populated
differently that the others, because currently there isn't a way to get line
numbers, etc. from the JSC -- I think?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.