[Webkit-unassigned] [Bug 20364] [XBL] Add shadow tree rendering

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 18 07:56:33 PDT 2008


------- Comment #3 from jchaffraix at webkit.org  2008-08-18 07:56 PDT -------
(In reply to comment #2)
> (From update of attachment 22759 [edit])
> This check looks wrong:
> f (templateElement->attached())
> tempalteElement is in the xbl doc, no?


However we cannot say whether it was attached or not, so that's why we need to
detach it before reattaching its children at the right place. If we do not do
that, we will hit some ASSERT while attaching the children.

> this one doens't need braces:
>  if (node->hasTagName(XBLNames::templateTag)) {

Right (silly mistake on my side which will be corrected before landing).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list