[Webkit-unassigned] [Bug 20364] [XBL] Add shadow tree rendering

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 16:56:56 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=20364


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22759|review?                     |review-
               Flag|                            |




------- Comment #2 from eric at webkit.org  2008-08-12 16:56 PDT -------
(From update of attachment 22759)
This check looks wrong:
f (templateElement->attached())

tempalteElement is in the xbl doc, no?

this one doens't need braces:
 if (node->hasTagName(XBLNames::templateTag)) {

Otherwise looks fine.

r- for the worng check.  I don't need to see this again, if you can convince me
over IRC that you've put the right check in instead of the templateElement
thing... well, and I guess you should add a test case too! :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list