[Webkit-unassigned] [Bug 15223] webkitdir.pm::isQt() is not working properly in run-webbkit-test under Linux/Qt

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15223


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16301|review?                     |review-
               Flag|                            |




------- Comment #2 from aroben at apple.com  2007-09-16 15:28 PDT -------
(From update of attachment 16301)
We prefer not to export global variables from perl modules. I think you should
follow the "x()/determineX()" pattern we use throughout webkitdirs.pm:

my $isQt;
sub determineIsQt()
{
    return if defined($isQt);
    $isQt = <something>;
}

sub isQt()
{
    determineIsQt();
    return $isQt;
}


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.