[Webkit-unassigned] [Bug 15223] webkitdir.pm::isQt() is not working properly in run-webbkit-test under Linux/Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 16 14:47:52 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=15223


julien.chaffraix at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16301|                            |review?
               Flag|                            |




------- Comment #1 from julien.chaffraix at gmail.com  2007-09-16 14:47 PDT -------
Created an attachment (id=16301)
 --> (http://bugs.webkit.org/attachment.cgi?id=16301&action=view)
proposed patch

With this patch, when calling isQt (same for isGdk), the comparison is done
once. The result is stored in a global variable and is given in the following
code.

The global variables ($isQt and $isGdk) are now exported to be used in
buid-dumprendertree.

The saving / regeneration of $isQt was removed in run-webkit-tests as it is not
necessary anymore (done directly in isQt()).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list