[Webkit-unassigned] [Bug 15691] [GTK] Public API does not follow GTK+ conventions

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15691


xan.lopez at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




------- Comment #2 from xan.lopez at gmail.com  2007-10-25 14:40 PDT -------
(In reply to comment #0)
> There is evidence that the WebKitPage class should instead be named *View to
> match GTK+ convention of widgets to be added to scrolled containers eg.
> TreeView and TextView.
> 
> It may also be prudent to follow GTK+ coding style in classes under
> WebKit/gtk/Api/ and perhaps WebKitSupport since its very much the convention
> when you are defining GObject classes in boilerplate-heavy C code.

+1 for this if there's no problem in doing it. The people more likely to
contribute to that code (I guess) are used to that style.

> 
> We may also want to introduce much of the new API in one go to avoid the
> situation where people add bits and pieces to scratch an itch, making it
> inconsistent. To this end, we may want to borrow from/adopt:
> 
> http://gtk-webcore.svn.sourceforge.net/viewvc/gtk-webcore/trunk/WebkitGtk/
> 
> I'm not entirely convinced by that API either. The delegate classes would need
> to go. Some of the entry point names are also rather lengthy.
> 
> We need to discuss these issues so we can move forward with a public API for
> WebKit/Gtk+ that can be supported in the long term, or even recommend for use
> in applications at all.
> 

Now that the ground work in Epiphany is done and we can start implementing some
big missing chunks in the webkit port I hope I'll be able to provide some
feedback there.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.