[Webkit-unassigned] [Bug 15378] WebKit GTK+ should use Font info from GtkStyle, and aliases, by default

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15378





------- Comment #5 from dobey at wayofthemonkey.com  2007-10-10 10:52 PDT -------
(In reply to comment #4)
> Does GtkStyle store a separate default font size for fixed vs. variable width
> fonts?

It only provides one PangoFontDescription, so unfortunately no, it doesn't
provide preferred monospace font information. I would certainly prefer to
access the font settings from GNOME, but these are only available in gconf.

> "defsize" should be renamed "defaultSize" to adhere to our coding style
> guidelines <http://webkit.org/coding/coding-style.html>.
> 
> +        defsize /= 1024;
> 
> Can we get this constant from a Pango header? If not, this constant should be a
> static const int at the top of the file.

This constant does appear to be defined in pango-types.h. I'm about to upload a
patch which fixes this and the variable name.

> You'll need to add a ChangeLog entry before this can be landed. See
> <http://webkit.org/coding/contributing.html> for instructions.

Also in updated patch that I'm about to attach.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.