[Webkit-unassigned] [Bug 6129] Incomplete implementation of CSS 2.1 system colors

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=6129


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mitz at webkit.org




------- Comment #19 from mitz at webkit.org  2007-11-28 17:57 PDT -------
(In reply to comment #18)
> (In reply to comment #17)
> > (From update of attachment 17571 [edit] [edit])
> >  232     return Color(static_cast<int>(256.0 * [color redComponent]),
> > static_cast<int>(256.0 * [color greenComponent]), static_cast<int>(256.0 *
> > [color blueComponent]));
> > 
> > You should be multiplying by 255 instead of 256.0
> > 
> 
> (From comment 14)
> The values that are 256 are that specifically because otherwise a number of
> colours end up rounding in such a way that values are off-by-one. Perhaps we
> should add a comment to the code to indicate this as it's a little unusual that
> it's not 255?
> 

Perhaps you're looking to multiply by nextafter(256.0, 0.0) (see Color.cpp).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.