[Webkit-unassigned] [Bug 6129] Incomplete implementation of CSS 2.1 system colors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 16:56:48 PST 2007


------- Comment #18 from proton at wiretapped.net  2007-11-28 16:56 PDT -------
(In reply to comment #17)
> (From update of attachment 17571 [edit])
>  232     return Color(static_cast<int>(256.0 * [color redComponent]),
> static_cast<int>(256.0 * [color greenComponent]), static_cast<int>(256.0 *
> [color blueComponent]));
> You should be multiplying by 255 instead of 256.0

(From comment 14)
The values that are 256 are that specifically because otherwise a number of
colours end up rounding in such a way that values are off-by-one. Perhaps we
should add a comment to the code to indicate this as it's a little unusual that
it's not 255?

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list