[Webkit-unassigned] [Bug 15879] Add evaluateToNumber fast path for numeric operations

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15879


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17102|0                           |1
        is obsolete|                            |
  Attachment #17106|                            |review?
               Flag|                            |




------- Comment #4 from eric at webkit.org  2007-11-07 02:12 PDT -------
Created an attachment (id=17106)
 --> (http://bugs.webkit.org/attachment.cgi?id=17106&action=view)
Improved patch, 0.7% improvement for Sunspider

I'm more interested in comments than I am a +/-.  It think this patch could
probably still use some tweaking.

One thing I've considered is adding a non-virtual
inlineEvaluateToNumber(ExecState*) call to certain nodes, which both evaluate()
and evaluateToNumber() can use.  It would need to be a class method, which
hopefully the compiler would be smart enough to inline.  Maybe I should just
make it a static inline and pass "this" along, but then I'd need to improve the
exception macros and possibly other functions (which could be done).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.