[Webkit-unassigned] [Bug 15879] Add evaluateToNumber fast path for numeric operations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 01:25:20 PST 2007


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #17101|0                           |1
        is obsolete|                            |

------- Comment #3 from eric at webkit.org  2007-11-07 01:25 PDT -------
Created an attachment (id=17102)
 --> (http://bugs.webkit.org/attachment.cgi?id=17102&action=view)
Improved patch, still a wash for SunSpider

For many tests this is a speedup, for a few though (like frannkuch) it's a
slowdown (there 2.5%).  I think most of that is due to Node::evaluateToNumber()
which not only adds a hadException check to places where it wasn't necessarily
before, but *more importantly* is a virtual call in the first place.  So we end
up making two virtual calls.  One way to get rid of that cost would be to have
further deployment of the evaluteToNumber() technique.  LessNode is one example
where I haven't yet tried.  Also all the ReadModifyAssignment nodes could use a
evaluateToNumber() implementation.  All of the places where we currently deal
with uints and ints instead of doubles could also benefit from evaluateToNumber
usage so long as there are functions in JSImmediate.h to convert from double ->
int/uint (and assuming that toNumber()->toWhateverTypeOfInt() is equivalent to
the current behavior.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list