[Webkit-unassigned] [Bug 11272] Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11272





------- Comment #14 from rwlbuis at gmail.com  2007-05-30 10:20 PDT -------
Hi Darin,

(In reply to comment #13)
> (From update of attachment 14784 [edit])
> +        rootElement()->setCurrentTranslate(FloatPoint(pos.x() -
> m_translate.x(), m_translate.y() - pos.y()));
> +        if (renderer())
> +            renderer()->repaint();
> 
> Shouldn't setCurrentTranslate be the code doing the repaint?

Right, that is better, will do.

> +        FloatPoint m_translate;
> 
> I think this should be removed.

I am not sure that is possible. We have to keep track of intermendiate results
like that I think.

> +    if (m_svgPan) {
> +        m_svgPan = false;
> +        return true;
> +    }
> 
> I think we want to do a final "updatePan" at the end location.

Right, will fix.

> +        m_width = float(m_width) * svg->currentScale();
> +        m_height = float(m_height) * svg->currentScale();
> 
> This still has the cast, even though you mentioned removing it in your
> comments.

Right, I searched for (float), should have searched for float(. Will also fix.
Patch will go to the feature branch.
Cheers,

Rob.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.