[Webkit-unassigned] [Bug 11272] Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 30 09:18:06 PDT 2007
http://bugs.webkit.org/show_bug.cgi?id=11272
darin at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14784|review? |review+
Flag| |
------- Comment #13 from darin at apple.com 2007-05-30 09:18 PDT -------
(From update of attachment 14784)
+ rootElement()->setCurrentTranslate(FloatPoint(pos.x() -
m_translate.x(), m_translate.y() - pos.y()));
+ if (renderer())
+ renderer()->repaint();
Shouldn't setCurrentTranslate be the code doing the repaint?
+ FloatPoint m_translate;
I think this should be removed.
+ if (m_svgPan) {
+ m_svgPan = false;
+ return true;
+ }
I think we want to do a final "updatePan" at the end location.
+ m_width = float(m_width) * svg->currentScale();
+ m_height = float(m_height) * svg->currentScale();
This still has the cast, even though you mentioned removing it in your
comments.
review+, although I think this needs a little refinement
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list