[Webkit-unassigned] [Bug 13565] Change svn-create-patch to put LayoutTests in the end

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13565





------- Comment #4 from ddkilzer at webkit.org  2007-05-20 07:03 PDT -------
(In reply to comment #3)
> (From update of attachment 14633 [edit])
> +        In addition reordering non-binary files under the LayoutTests
> directory, this
> 
> Typo: "In addition" -> "In addition to"

Thanks!

> +        $dir = File::Spec->catdir($dirs[0], ".svn") if -d $dirs[0];
> +        $dir = File::Spec->catdir(dirname($dirs[0]), ".svn") if -f $dirs[0];
> 
> It would be nice not to repeat the catdir call -- can you put the directory
> name in a local and then call catdir?

It won't because the 'if' part of the statement will be executed first in both
lines, and a path can't be both a file and a directory.

Regardless, the code is confusing to read, so I'll change this anyway.  :)

> +# Generate the diff for text files, layout files then binary files for easy
> reviewing
> 
> "layout files" is a confusing term (and "layoutFiles" is a similarly misleading
> variable name). Perhaps "test files"/"testFiles" would be more appropriate?

"layoutTestsFiles"?  (Kidding!)  I'll change it to "test files"/"testFiles" and
land.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.