[Webkit-unassigned] [Bug 13565] Change svn-create-patch to put LayoutTests in the end

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13565


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14633|review?                     |review+
               Flag|                            |




------- Comment #3 from aroben at apple.com  2007-05-20 00:26 PDT -------
(From update of attachment 14633)
+        In addition reordering non-binary files under the LayoutTests
directory, this

Typo: "In addition" -> "In addition to"

+        $dir = File::Spec->catdir($dirs[0], ".svn") if -d $dirs[0];
+        $dir = File::Spec->catdir(dirname($dirs[0]), ".svn") if -f $dirs[0];

It would be nice not to repeat the catdir call -- can you put the directory
name in a local and then call catdir?

+# Generate the diff for text files, layout files then binary files for easy
reviewing

"layout files" is a confusing term (and "layoutFiles" is a similarly misleading
variable name). Perhaps "test files"/"testFiles" would be more appropriate?

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.