[Webkit-unassigned] [Bug 13344] pdf file is getting opened in a new window using adobe plugin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 09:04:37 PDT 2007


------- Comment #10 from darin at apple.com  2007-05-11 09:04 PDT -------
(From update of attachment 14407)
+    // http://bugs.webkit.org/show_bug.cgi?id=10015
+    // If the type attribute is given as application/pdf in OBJECT tag, 
+    // it should use the Adobe plugin to open the pdf file instead of opening
it as an image.

+    if (!m_serviceType.isEmpty() && equalIgnoringCase(m_serviceType,
+       return false;

Given the comment, the code seems to assume that there's always a plug-in
installed. Is that right? Have you tested what impact this change has when
there is not a plug-in installed?

+                  if (equalIgnoringCase(name, "type") &&
!serviceType.isEmpty() ) 

There's an extra space before the trailing parenthesis.

Do these new layout tests require that people install the Adobe plug-in? Or do
they work without the plug-in?

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list