[Webkit-unassigned] [Bug 13344] pdf file is getting opened in a new window using adobe plugin

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13344


madhu.mukund at wipro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14407|                            |review?
               Flag|                            |




------- Comment #9 from madhu.mukund at wipro.com  2007-05-07 17:54 PDT -------
Created an attachment (id=14407)
 --> (http://bugs.webkit.org/attachment.cgi?id=14407&action=view)
New patch for this issue and issue #10015 regarding plugins

I am submitting a new patch for this issue. In this I am following the (2)
method in my previous comment. Please see the details below

If the 'type' attribute is having wrong value, it is getting validated and the
correct value is being set to 'serviceType' from the data attribute. So the
parameter serviceType is ensured to have a correct value. But after this, if
the 'paramNames' include type and a wrong value in 'paramValues', the plugin is
getting opened in a new window. The serviceType seems to be getting overridden
by this value.

To solve this there are two ways.

1. Remove the type from the paramNames and its value from the paramValues, once
type is set to 'serviceType'. (I have followed this in my previous patch).

2. Set the correct value of type in 'paramValues' from 'serviceType'.(This
method is followed in this patch).

Could you please review this and give comments ?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.