[Webkit-unassigned] [Bug 14111] Autogenerate Event JS binding

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14111


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14991|0                           |1
        is obsolete|                            |
  Attachment #15042|                            |review?
               Flag|                            |




------- Comment #3 from sam at webkit.org  2007-06-14 23:38 PDT -------
Created an attachment (id=15042)
 --> (http://bugs.webkit.org/attachment.cgi?id=15042&action=view)
Update patch

>Is there no way to avoid special-casing clipboardData and dataTransfer? Can't
>we just move those to the appropriate event classes?

I have moved dataTransfer into MouseEvent (though perhaps it should be in a
DragEvent class that we don't have) but have to special-case clipboardData for
now as we have no JSClipboardEvent event class to push it into yet.  If you
think it is appropriate, I can create one and put the method there.

>+    // FIXME: Is this lock necessary?
>+    KJS::JSLock lock;
>
> Seems clear that it is.

Oops, didn't mean to leave that in,  Removed.

>+            if (WebCore::JSUnprotectedEventListener* listener =
>static_cast<WebCore::JSUnprotectedEventListener*>(m_impl->onReadyStateChangeListener()))
>Why is the WebCore prefix needed?

Fixed.

>-        [OldStyleObjC] void initEvent(in DOMString eventTypeArg, 
>+        [OldStyleObjC] void initEvent(in AtomicString eventTypeArg, 
>
>This seems wrong. The API should be DOMString even though the implementation is
>AtomicString.

Fixed.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.